Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.60.0 #1689

Merged
merged 9 commits into from
Nov 21, 2023
Merged

0.60.0 #1689

merged 9 commits into from
Nov 21, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Nov 21, 2023

v0.60.0

  • is-714/chore: add copy and layout changes #1687
  • IS-780 fix(height): fix editor + preview heights #1686
  • IS-782-Editor-File-text-always-comes-out-as-file-regardless-of-text #1685
  • feat(rte): use proper node for FormSG embed #1682
  • feat(tiptap): update icon options and use boxicons #1683
  • fix(media): bring the user back to the select media modal screen after upload #1684
  • 0.59.0 #1680

kishore03109 and others added 7 commits November 16, 2023 19:20
* feat(assets): add icon assets for table actions

* feat(tiptap): update icon options and use boxicons

* style(editor): adjust text styling and spacing based on design feedback

* style(tiptap): update tooltip copies for some options
* feat(rte): use proper node for FormSG embed

* fix(rte): adjust imports

* chore(rte): remove unused import

* chore(tiptap): extract priority to constant
…1685)

* fix(bubbleMenu): only allow change link for files

* feat(image): use image src, not base64

* feat(getMediaSrc): load media src

* fix(wrapAroundDiv): wrap the img ard a div...
to prevent the p to be rendered

* fix(image): change to wrapper

* chore(image): rm redundant overload
* IS-780 fix(height): fix editor + preview heights

* fix(height): use screen height instead
* chore: add copy and layout changes

* chore: bold text and set close indentation
@kishore03109 kishore03109 requested a review from dcshzj November 21, 2023 08:11
Copy link

mergify bot commented Nov 21, 2023

⚠️ The sha of the head commit of this PR conflicts with #1690. Mergify cannot evaluate rules on this PR. ⚠️

@kishore03109
Copy link
Contributor Author

kishore03109 commented Nov 21, 2023

#1685
@dcshzj

Tests

  • Create a file with a name. Notice that the editor should show that name rather than just 'file'
  • Create a image + save
  • Note that the newly created image is not base 64, but rather a source
  • Type some words below the image
  • Note that there is no <p> </p> tags below the image

#1686 and #1687 verified

* fix(input): empty input validation

* fix(touch): on touch
@mergify mergify bot mentioned this pull request Nov 21, 2023
@kishore03109 kishore03109 merged commit b861abd into master Nov 21, 2023
19 of 22 checks passed
@mergify mergify bot deleted the release/0.60.0 branch November 21, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants